Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added [Unit Tests] - ValidateTicketReviewRequest #2299

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Added [Unit Tests] - ValidateTicketReviewRequest #2299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions utils/ticket_processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package utils

import (
"errors"
"strings"
)

type TicketReviewRequest struct {
Expand All @@ -16,10 +17,13 @@ type TicketReviewRequest struct {
}

func ValidateTicketReviewRequest(req *TicketReviewRequest) error {
if req.Value.TicketUUID == "" {
if req == nil {
return errors.New("nil request")
}
if strings.TrimSpace(req.Value.TicketUUID) == "" {
return errors.New("ticketUUID is required")
}
if req.Value.TicketDescription == "" {
if strings.TrimSpace(req.Value.TicketDescription) == "" {
return errors.New("ticketDescription is required")
}
return nil
Expand Down
185 changes: 185 additions & 0 deletions utils/ticket_processor_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,185 @@
package utils

import (
"strings"
"testing"

"github.com/stretchr/testify/assert"
)

func TestValidateTicketReviewRequest(t *testing.T) {
tests := []struct {
name string
input *TicketReviewRequest
wantErr string
}{
{
name: "valid request",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
TicketUUID: "test-uuid",
TicketDescription: "test description",
},
},
wantErr: "",
},
{
name: "missing ticket UUID",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
TicketDescription: "test description",
},
},
wantErr: "ticketUUID is required",
},
{
name: "missing ticket description",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
TicketUUID: "test-uuid",
},
},
wantErr: "ticketDescription is required",
},
{
name: "Both TicketUUID and TicketDescription Empty",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
TicketUUID: "",
TicketDescription: "",
},
},
wantErr: "ticketUUID is required",
},
{
name: "Nil Request",
input: nil,
wantErr: "nil request",
},
{
name: "Whitespace TicketUUID",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
TicketUUID: " ",
TicketDescription: "This is a valid ticket description",
},
},
wantErr: "ticketUUID is required",
},
{
name: "Whitespace TicketDescription",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
TicketUUID: "123e4567-e89b-12d3-a456-426614174000",
TicketDescription: " ",
},
},
wantErr: "ticketDescription is required",
},
{
name: "Large TicketDescription",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
TicketUUID: "123e4567-e89b-12d3-a456-426614174000",
TicketDescription: strings.Repeat("a", 10000),
},
},
wantErr: "",
},
{
name: "Non-UUID TicketUUID",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
TicketUUID: "not-a-uuid",
TicketDescription: "This is a valid ticket description",
},
},
wantErr: "",
},
{
name: "With Optional Fields",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
FeatureUUID: "feature-123",
PhaseUUID: "phase-456",
TicketUUID: "ticket-789",
TicketDescription: "test description",
},
},
wantErr: "",
},
{
name: "With RequestUUID and SourceWebsocket",
input: &TicketReviewRequest{
Value: struct {
FeatureUUID string `json:"featureUUID"`
PhaseUUID string `json:"phaseUUID"`
TicketUUID string `json:"ticketUUID" validate:"required"`
TicketDescription string `json:"ticketDescription" validate:"required"`
}{
TicketUUID: "ticket-789",
TicketDescription: "test description",
},
RequestUUID: "req-123",
SourceWebsocket: "ws://example.com",
},
wantErr: "",
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
err := ValidateTicketReviewRequest(tt.input)
if tt.wantErr == "" {
assert.NoError(t, err)
} else {
assert.EqualError(t, err, tt.wantErr)
}
})
}
}
Loading