-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/people page right click - resolved #1425
Bug/people page right click - resolved #1425
Conversation
Hi @ecurrencyhodler , the issue is resolved as shown in the video. I have also added highlights on the person card while hovering with the mouse arrow. The card was being treated as an image due to which there was no option to open in a new window. Now it is available. |
Awesome. When you right click, are you opening the profile in a new tab? |
Yes its working |
Okay let's get a code review. Gj! |
@hritikmunde your change messes up with the people card design, and also remove the hover color change |
Okay sure |
Hi @elraphty , working fine on my machine. Removed the hover effect. |
all check pass. @elraphty can you take another look? |
Hi! can you resubmit this PR to this new frontend repo? https://github.com/stakwork/sphinx-tribes-frontend |
@ecurrencyhodler , yeah sure. Are you gonna create an issue for me to reference or should I just create a PR? |
Create the PR but link to the same issue. |
okay will create a PR and link to this issue |
closing this PR |
Issue ticket number and link
closes #1406
Please delete options that are not relevant.
Checklist before requesting a review
right-click-working.mp4