Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/people page right click - resolved #1425

Closed

Conversation

hritikmunde
Copy link
Contributor

Issue ticket number and link

closes #1406

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend
right-click-working.mp4

@hritikmunde
Copy link
Contributor Author

hritikmunde commented Jan 19, 2024

Hi @ecurrencyhodler , the issue is resolved as shown in the video. I have also added highlights on the person card while hovering with the mouse arrow. The card was being treated as an image due to which there was no option to open in a new window. Now it is available.

@ecurrencyhodler
Copy link
Contributor

Awesome. When you right click, are you opening the profile in a new tab?

@hritikmunde
Copy link
Contributor Author

Yes its working

@ecurrencyhodler
Copy link
Contributor

Okay let's get a code review. Gj!

@elraphty
Copy link
Contributor

@hritikmunde your change messes up with the people card design, and also remove the hover color changePeople List

@hritikmunde
Copy link
Contributor Author

Okay sure

@hritikmunde
Copy link
Contributor Author

Hi @elraphty , working fine on my machine. Removed the hover effect.
image

@ecurrencyhodler
Copy link
Contributor

all check pass. @elraphty can you take another look?

@ecurrencyhodler
Copy link
Contributor

Hi! can you resubmit this PR to this new frontend repo? https://github.com/stakwork/sphinx-tribes-frontend

@hritikmunde
Copy link
Contributor Author

@ecurrencyhodler , yeah sure. Are you gonna create an issue for me to reference or should I just create a PR?

@ecurrencyhodler
Copy link
Contributor

Create the PR but link to the same issue.

@hritikmunde
Copy link
Contributor Author

okay will create a PR and link to this issue

@hritikmunde
Copy link
Contributor Author

closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable opening a new tab by right clicking on the people page.
3 participants