Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Prettier Issue #858

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Conversation

aliraza556
Copy link
Contributor

@aliraza556 aliraza556 commented Jan 3, 2025

Describe your changes

Issue ticket number and link: https://community.sphinx.chat/p/csb4dj2tu2rqjmn086qg/assigned/3170/0

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@aliraza556
Copy link
Contributor Author

Hi @humansinstitute Please review this PR.

@aliraza556
Copy link
Contributor Author

@humansinstitute Added here #860

@humansinstitute
Copy link
Collaborator

Can you describe whats going on in this change?

@tobi-bams - thoughts?

@aliraza556
Copy link
Contributor Author

@humansinstitute:
The Prettier formatting check is failing in GitHub workflows while passing locally on Windows due to inconsistent line endings (CRLF vs LF). Windows uses CRLF (\r\n) line endings by default, while Unix/Linux systems use LF (\n). This inconsistency causes the formatting check to fail when the code is pushed to GitHub, even though it passes locally.

@tobi-bams
Copy link
Collaborator

@humansinstitute: The Prettier formatting check is failing in GitHub workflows while passing locally on Windows due to inconsistent line endings (CRLF vs LF). Windows uses CRLF (\r\n) line endings by default, while Unix/Linux systems use LF (\n). This inconsistency causes the formatting check to fail when the code is pushed to GitHub, even though it passes locally.

@humansinstitute yea, I think this is correct, if you look through the code base you can't see any vivid change it's just an issue with how his local machine handled formatting.

@tobi-bams
Copy link
Collaborator

@aliraza556 please the cypress test is failing

@aliraza556
Copy link
Contributor Author

@tobi-bams No issue here, it seems to have failed randomly.

@aliraza556
Copy link
Contributor Author

@tobi-bams randomly failed cypress issue fixed here

#820

@aliraza556
Copy link
Contributor Author

@humansinstitute: The Prettier formatting check is failing in GitHub workflows while passing locally on Windows due to inconsistent line endings (CRLF vs LF). Windows uses CRLF (\r\n) line endings by default, while Unix/Linux systems use LF (\n). This inconsistency causes the formatting check to fail when the code is pushed to GitHub, even though it passes locally.

@humansinstitute yea, I think this is correct, if you look through the code base you can't see any vivid change it's just an issue with how his local machine handled formatting.

@tobi-bams Please see this PR #864

if looks good then complete project need prettier like this PR: #706

@humansinstitute humansinstitute merged commit fb7f0bd into stakwork:master Jan 4, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants