Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add image paste functionality to text area #806

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

jordan-ae
Copy link
Contributor

Describe your changes

Issue ticket: #789

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@jordan-ae
Copy link
Contributor Author

@humansinstitute everything is working to spec but the endpoint for uploads keeps returning a 404. Not sure what's up implementation is on point. Can we double check the endpoint please? I've been debugging for hours now and atp I'm not sure what's going on

Screencast.from.2024-12-20.14-43-22.webm

@humansinstitute
Copy link
Collaborator

@tobi-bams can you review and advise on the endpoint?

disabled={isCopying}
data-testid="copy-description-btn"
>
{isPreview ? 'Preview' : 'Edit'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is in preview state, the Edit button should be what is visible and when it's in Edit phase the button should say Edit.

@tobi-bams
Copy link
Collaborator

@humansinstitute everything is working to spec but the endpoint for uploads keeps returning a 404. Not sure what's up implementation is on point. Can we double check the endpoint please? I've been debugging for hours now and atp I'm not sure what's going on

Screencast.from.2024-12-20.14-43-22.webm

@jordan-ae you are correct, So sorry the mistake is from my end.

The /public_pic endpoint has been removed, we now use the meme_upload endpoint. But don't worry I will handle this myself. Currently the meme_upload is not working properly because we've fully migrated to v2. I need to chat Evan up.
@humansinstitute

@humansinstitute
Copy link
Collaborator

@tobi-bams - thanks for letting me know. Can you tag me when thats done and we can merge this?

looking forward to getting this functionality!

@humansinstitute
Copy link
Collaborator

@tobi-bams - I'm going to merge this and payout bounty for now.

I think we can revisit and update the endpoint when you have had a chance to talk to Evan.

@humansinstitute humansinstitute merged commit e9e0c91 into stakwork:master Dec 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants