Add provider filter to superadmin #341
Conversation
|
Thanks for the video and also demonstrating scrolling. I noticed that once a provider has been selected the other providers are hidden until clear is pressed. Let's instead keep all providers visible. Just preserve the check marks if they've been selected. |
Done |
|
LGTM Thanks. Let's get a code review. |
| </ProviderContianer> | ||
| )) | ||
| ) : ( | ||
| <p>No provider with such alias</p> |
There was a problem hiding this comment.
No provider available, should be message when the provider length is empty
There was a problem hiding this comment.
@elraphty Addressed
| > | ||
| <ProviderContainer> | ||
| <ProvidersListContainer> | ||
| {providers && providers.length > 0 ? ( |
There was a problem hiding this comment.
Add an intersection observer to load more providers on scroll when the provider length is more than 5
There was a problem hiding this comment.
Hi @elraphty! Why is there a need for the Intersection Observer to load more providers on scroll when we are already receiving all provider data from the metrics/bounties endpoint call? We are not making another call for additional providers unless triggered by changes in the date filter, for example. So, my point is, since we already have all providers, it would be more appropriate to implement the Intersection Observer if we need to call the API to get more providers. Could you please correct me if I am wrong or guide me?
|
Provider dropdown is not inline with the other dropdowns |
|
@elraphty Addressed 
|
|
@elraphty @ecurrencyhodler I think we might want to do the filtering by provider from the backend doing it from the frontend will lead to inaccurate results, I would rather us do it by backend first instead of creating a frontend change that we'll need to fix in the future. I think we may have not scoped this issue well enough let me know what you think |
|
@kevkevinpal We are already doing filtering by provider from the backend as you can see here |
Take a look at @AbdulWahab3181 https://www.loom.com/share/818e0e9267a84332baabc9949edd847f the provider list is inaccurate, I will go with @kevkevinpal suggestion the provider list should come from the backend. |
|
@elraphty, I understand why you're only seeing two providers. We're currently displaying unique providers sourced from the metrics/bounties endpoint. When you select a 90-day or custom date range, the metrics/bounties endpoint is called with a limit of 20. Consequently, we receive 20 bounties related to 2 providers. If you wish to view other providers, please navigate to the next pages, as demonstrated in the attached video. You're correct that the provider list comes from the backend for greater accuracy, but this wasn't within the scope of our current task. Additionally, there isn't an endpoint available in the backend that provides the list of providers. I propose closing this task after merging and creating two new tasks: one for the backend to provide the list of providers and another for the frontend to display these providers. |
elraphty
force-pushed
the
superadmin-provider-filter
branch
from
4d0e0b9 to
62f9616
Compare
|
@AbdulWahab3181 so we can bump your bounty amount up 200k sats and can you then implement a filter on the API instead to filter by providers? Right now we are filtering by the bounties we have on the frontend which will lead to poor results @elraphty can work on the backend to create the new query param for the provider filter |
|
For now we can keep this PR up |
@kevkevinpal Thanks for considering the increase in bounty. Sure, I would do that once the provider list endpoint is ready on the backend. |
|
Updated bounty. I'll create a ticket for raph: https://community.sphinx.chat/bounty/1582 |
|
@AbdulWahab3181 ${Host}/metrics/bounties/providers?page=1&Open=false&Assigned=true&Paid=true&direction=desc&limit=5, this will return the providers list |
…Wahab3181/sphinx-tribes-frontend into superadmin-provider-filter
|
@elraphty @ecurrencyhodler I am receiving an 'access denied' message when trying to access the admin page. Could you please investigate on the backend? 
|
|
I'm also encountering a 404 error when calling the metrics/bounties/providers endpoint. It was functioning properly just a minute before the access denied issues occurred 
|
|
@AbdulWahab3181 This worked for me https://people-test.sphinx.chat/metrics/bounties/providers?page=1&Open=false&Assigned=true&Paid=true&direction=desc&limit=5 Just make sure you pass the {
"start_date": "1709209136",
"end_date": "1709813936"
} |
|
@elraphty Now, It's working for me as well |
|
@elraphty I have Implemented provider list endpoint. Could you please have a look, also review and merge the PR? |
| route_hint?: string; | ||
| owner_route_hint?: string; | ||
| owner_contact_key?: string; | ||
| price_to_meet: number; |
There was a problem hiding this comment.
@AbdulWahab3181 Just import the Person interface from main.ts, instead of duplicating it.
There was a problem hiding this comment.
@AbdulWahab3181 Just import the Person interface from main.ts, instead of duplicating it.
Nice work @AbdulWahab3181 just fix this, so I can merge.
There was a problem hiding this comment.
@elraphty Thanks, Addressed
Describe your changes
https://www.loom.com/share/a5f1eaa0dfec44ed96f828cc0dd5852b
Issue ticket number and link
Closes #294
Type of change
Please delete options that are not relevant.
Checklist before requesting a review