Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement date recency #545

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Implement date recency #545

merged 4 commits into from
Nov 2, 2023

Conversation

Jeezman
Copy link
Contributor

@Jeezman Jeezman commented Nov 2, 2023

closes #529

What does this PR do?

  • Implements date recency on content
  • Implement test

screenshots

Screen Shot 2023-11-02 at 1 04 22 AM Screen Shot 2023-11-02 at 1 03 03 AM Screen Shot 2023-11-02 at 1 03 45 AM

Copy link
Collaborator

@kevkevinpal kevkevinpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt just added one comment about a diff I saw in getLsat

Nice work on the tests!
not sure if these cypress tests are included in the git actions already but we should add them aswell

src/utils/getLSat/index.ts Show resolved Hide resolved
src/utils/getLSat/index.ts Show resolved Hide resolved
- Config cypress to run component tests
- implement tests for date recency
- config update
- update cypress config
- update TypeTweet test file
- add window.localStorage
@kevkevinpal
Copy link
Collaborator

I seem to be having trouble getting the test coverage from the component cypress test going to revert my commits

@kevkevinpal kevkevinpal merged commit 1c9d36f into stakwork:master Nov 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add recency of the content
2 participants