Skip to content

Commit

Permalink
Fix bug with empty image path (#140)
Browse files Browse the repository at this point in the history
fix bug with empty image path
  • Loading branch information
karl-johan-grahn authored Dec 13, 2024
1 parent 4acc0ce commit 112a537
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/pull_request_container_build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ on:
default: ""
required: false
type: string
secrets:
CONTAINER_REGISTRY_URL:
description: "Container registry to publish docker image"
required: true
type: string
secrets:
CONTAINER_REGISTRY_USERNAME:
description: "Username to login to container registry"
required: true
Expand Down Expand Up @@ -56,7 +57,7 @@ jobs:
- name: Generate image repository path
id: image_repo_path
run: |
echo "IMAGE_REPOSITORY=$(echo ${{ secrets.CONTAINER_REGISTRY_URL }}/${{ github.event.repository.name }} | tr '[:upper:]' '[:lower:]')" >> $GITHUB_OUTPUT
echo "IMAGE_REPOSITORY=$(echo ${{ inputs.CONTAINER_REGISTRY_URL }}/${{ github.event.repository.name }} | tr '[:upper:]' '[:lower:]')" >> $GITHUB_OUTPUT
- name: Generate image tag
id: generate_tag
Expand All @@ -81,7 +82,7 @@ jobs:
- name: Login to Registry
uses: docker/login-action@v3
with:
registry: ${{ secrets.CONTAINER_REGISTRY_URL }}
registry: ${{ inputs.CONTAINER_REGISTRY_URL }}
username: ${{ secrets.CONTAINER_REGISTRY_USERNAME }}
password: ${{ secrets.CONTAINER_REGISTRY_PASSWORD }}

Expand Down

0 comments on commit 112a537

Please sign in to comment.