Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(itinerary): add walking step instructions #817

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

andreashelms
Copy link
Collaborator

@andreashelms andreashelms commented Nov 14, 2024

closes #814

image

@hbruch
Copy link

hbruch commented Nov 16, 2024

Looks good already. Please distinguish the different turns (slight, regular, sharp) explicitly in text and image. For icons, icon-sets.iconify.design should provide most of (e.g. roundabout-left arrow-sharp-turn-right, turn-slight-left etc). For the text instructions, please harmonize with the ones used by the App (see i.e. stadtnavi/stadtnavi_app#373).

Copy link

@hbruch hbruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@andreashelms andreashelms force-pushed the feat/walking-step-descriptions branch 2 times, most recently from df97d30 to bedf4cb Compare November 19, 2024 10:36
@andreashelms andreashelms merged commit 7cc2b32 into next Nov 19, 2024
5 checks passed
@andreashelms andreashelms deleted the feat/walking-step-descriptions branch November 19, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add walking step descriptions
2 participants