adding ADMIN_PASSWORD env var #50
Conversation
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
- Coverage 58.37% 58.10% -0.27%
==========================================
Files 8 8
Lines 663 666 +3
==========================================
Hits 387 387
- Misses 276 279 +3
Continue to review full report at Codecov.
|
| @@ -89,7 +89,9 @@ export function getConfig() { | |||
| if (process.env.BSK_SUBDOMAIN_OWNER_KEY) { | |||
| config.ownerKey = process.env.BSK_SUBDOMAIN_OWNER_KEY | |||
| } | |||
|
|
|||
| if (process.env.ADMIN_PASSWORD) { | |||
| config.ownerKey = process.env.ADMIN_PASSWORD || configDevelopDefaults.ADMIN_PASSWORD | |||
There was a problem hiding this comment.
configDevelopDefaults.ADMIN_PASSWORD is not defined
| config.ownerKey = process.env.ADMIN_PASSWORD || configDevelopDefaults.ADMIN_PASSWORD | |
| config.ownerKey = process.env.ADMIN_PASSWORD || ADMIN_PASSWORD |
There was a problem hiding this comment.
wouldn't that be from here? https://github.com/blockstack/subdomain-registrar/blob/fix/adminpass-var/src/developmode.js#L9
There was a problem hiding this comment.
No, configDevelopDefaults is a variable defined up above in this same file: https://github.com/blockstack/subdomain-registrar/blob/0b091b1f521af8f540960a4f74b915bfaa71c88b/src/config.js#L5
Description
Adds a new env var
ADMIN_PASSWORDso it doesn't have to be hard-coded in the config file asadminPassword: xxxxxFor details refer to issue #47
Type of Change