fix maintenance description (#102)

fix maintenance description When a maintenance didn't have a description, it could lead to Internal Server Error. This fixes the issue. Reviewed-by: Vladimir Hasko <[email protected]>
stackmon · Feb 8, 2024 · e3c9fd5 · e3c9fd5
1 parent fa3bf67
commit e3c9fd5
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/app/web/templates/incident.html b/app/web/templates/incident.html
@@ -7,7 +7,13 @@ <h4><i class="bi sd-{{ config['INCIDENT_IMPACTS'][incident.impact].key }}"></i>
     {{ incident.text }}</h4>
   {% if incident.impact == 0 %}
   <p class="indent">
-  {{ (incident.updates | selectattr('status', 'equalto', 'description') | first).text }}
+  {% set desc = incident.updates
+    | selectattr('status', 'equalto', 'description')
+    | first
+    | default(None) %}
+  {% if desc %}
+    {{ desc.text }}
+  {% endif %}
   {% block add_message %}
     {% include 'message.html' ignore missing %}
   {% endblock %}

diff --git a/app/web/templates/index.html b/app/web/templates/index.html
@@ -132,7 +132,13 @@ <h4 class="alert-heading">
                   href="incidents/{{incident.id}}"> {{ incident.text }}</a>
         </h4>
       <p class="indent">
-      {{ (incident.updates | selectattr('status', 'equalto', 'description') | first).text }}
+      {% set desc = incident.updates
+        | selectattr('status', 'equalto', 'description')
+        | first
+        | default(None) %}
+      {% if desc %}
+        {{ desc.text }}
+      {% endif %}
       {% block add_message %}
         {% include 'message.html' ignore missing %}
       {% endblock %}