Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hpctests to obey UCX_NET_DEVICES when RoCE devices present #421

Merged
merged 7 commits into from
Aug 7, 2024

Conversation

bertiethorpe
Copy link
Member

@bertiethorpe bertiethorpe commented Aug 7, 2024

Adds openmpi runtime options to prevent openmpi's own RoCE detection overriding UCX_NET_DEVICES, if set. See openucx/ucx#10049 for more information.

@bertiethorpe bertiethorpe self-assigned this Aug 7, 2024
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a comment here explaining why these magic works, and pointing to your UCX thread please? Otherwise this will be a head-scratcher for someone!

@sjpb sjpb changed the title Update hpctests to allow UCX_NET_DEVICES configuration Update hpctests to obey UCX_NET_DEVICES when RoCE devices present Aug 7, 2024
@sjpb sjpb marked this pull request as ready for review August 7, 2024 13:44
@sjpb sjpb requested a review from a team as a code owner August 7, 2024 13:44
bertiethorpe

This comment was marked as outdated.

@bertiethorpe bertiethorpe requested a review from sjpb August 7, 2024 14:15
@sjpb sjpb merged commit bd2de50 into main Aug 7, 2024
1 check passed
@sjpb sjpb deleted the fix/hpctests_ucx_net_devices branch August 7, 2024 14:27
bertiethorpe added a commit that referenced this pull request Aug 9, 2024
* Turn off higher priority MPI net devices

* Update pingmatrix.sh.j2

* Update pingmatrix.sh.j2

* Update pingpong.sh.j2

* Replace j2 comments with bash

* Update pingpong.sh.j2

---------

Co-authored-by: Steve Brasier <[email protected]>
sjpb added a commit that referenced this pull request Aug 14, 2024
* add trivy image scanning

* bump fatimage workflow to ubuntu 22.04

* make setup script work in CI TODO: FIXME

* fix libguestfs install

* run only 1x build per matrix entry, & only builds required

* fix packer README

* fix image download

* Use shorter names for CI clusters (#415)

* use run_number as a shorter ID for CI

* slurmci group name warning

* Revert "slurmci group name warning"  - underscores not valid linux hostname and stripped in host, leading to slurmdbd config failure

This reverts commit 61dfad6.

---------

Co-authored-by: Bertie <[email protected]>

* install ood apps in fatimage

* add ood jupyter install to fatimage

* jupyter_compute ood into fatimage

* bump fatimage

* allow items in compute mapping to have different keys e.g. only specify image_id for some compute groups (#412)

* Support ansible-init for remote collections (#411)

* Add ansible-init role to requirements.yml

* Add ansible-init to groups and plays

* Configure cluster_infra ansible-init metadata

* Only run site.yml once ansible-init has completed

* Wait for ansible init to finish before running bootstrap

* revert to using cluster_infra metadata defaults

* update image

* revert sausage bastion changes

* set ansible_init_wait as common var

* use run_number as a shorter ID for CI

* install ood apps in fatimage

* add ood jupyter install to fatimage

* bump image

* jupyter_compute ood into fatimage

* bump fatimage for jupyter_compute ood

* Update stackhpc.yml

* duplicate tuned inventory group name

* Fix invalid group name for slurmci

* Update stackhpc.yml

undo groupname changes

* slurmci group name warning

* rm ood changes

* bump fatimage

* change azimuth collection in bootstrap

* update azimuth image utils version

* update requirements

* Update bastion.yml

* Use azimuth image utils collection for ansible-init

* bump fatimage

---------

Co-authored-by: bertie <[email protected]>
Co-authored-by: bertiethorpe <[email protected]>

* avoid python-openstackclient v7 due to rebuild bug (#420)

* Update hpctests to obey UCX_NET_DEVICES when RoCE devices present (#421)

* Turn off higher priority MPI net devices

* Update pingmatrix.sh.j2

* Update pingmatrix.sh.j2

* Update pingpong.sh.j2

* Replace j2 comments with bash

* Update pingpong.sh.j2

---------

Co-authored-by: Steve Brasier <[email protected]>

* delete trivy scanned vulnerabilities

* update grafana

* bump image

* Update environments/.stackhpc/hooks/post.yml

Co-authored-by: Steve Brasier <[email protected]>

* Update setup-env.sh

---------

Co-authored-by: Bertie <[email protected]>
Co-authored-by: bertiethorpe <[email protected]>
Co-authored-by: bertiethorpe <[email protected]>
MaxBed4d pushed a commit that referenced this pull request Oct 15, 2024
* Turn off higher priority MPI net devices

* Update pingmatrix.sh.j2

* Update pingmatrix.sh.j2

* Update pingpong.sh.j2

* Replace j2 comments with bash

* Update pingpong.sh.j2

---------

Co-authored-by: Steve Brasier <[email protected]>
MaxBed4d pushed a commit that referenced this pull request Oct 15, 2024
* add trivy image scanning

* bump fatimage workflow to ubuntu 22.04

* make setup script work in CI TODO: FIXME

* fix libguestfs install

* run only 1x build per matrix entry, & only builds required

* fix packer README

* fix image download

* Use shorter names for CI clusters (#415)

* use run_number as a shorter ID for CI

* slurmci group name warning

* Revert "slurmci group name warning"  - underscores not valid linux hostname and stripped in host, leading to slurmdbd config failure

This reverts commit 61dfad6.

---------

Co-authored-by: Bertie <[email protected]>

* install ood apps in fatimage

* add ood jupyter install to fatimage

* jupyter_compute ood into fatimage

* bump fatimage

* allow items in compute mapping to have different keys e.g. only specify image_id for some compute groups (#412)

* Support ansible-init for remote collections (#411)

* Add ansible-init role to requirements.yml

* Add ansible-init to groups and plays

* Configure cluster_infra ansible-init metadata

* Only run site.yml once ansible-init has completed

* Wait for ansible init to finish before running bootstrap

* revert to using cluster_infra metadata defaults

* update image

* revert sausage bastion changes

* set ansible_init_wait as common var

* use run_number as a shorter ID for CI

* install ood apps in fatimage

* add ood jupyter install to fatimage

* bump image

* jupyter_compute ood into fatimage

* bump fatimage for jupyter_compute ood

* Update stackhpc.yml

* duplicate tuned inventory group name

* Fix invalid group name for slurmci

* Update stackhpc.yml

undo groupname changes

* slurmci group name warning

* rm ood changes

* bump fatimage

* change azimuth collection in bootstrap

* update azimuth image utils version

* update requirements

* Update bastion.yml

* Use azimuth image utils collection for ansible-init

* bump fatimage

---------

Co-authored-by: bertie <[email protected]>
Co-authored-by: bertiethorpe <[email protected]>

* avoid python-openstackclient v7 due to rebuild bug (#420)

* Update hpctests to obey UCX_NET_DEVICES when RoCE devices present (#421)

* Turn off higher priority MPI net devices

* Update pingmatrix.sh.j2

* Update pingmatrix.sh.j2

* Update pingpong.sh.j2

* Replace j2 comments with bash

* Update pingpong.sh.j2

---------

Co-authored-by: Steve Brasier <[email protected]>

* delete trivy scanned vulnerabilities

* update grafana

* bump image

* Update environments/.stackhpc/hooks/post.yml

Co-authored-by: Steve Brasier <[email protected]>

* Update setup-env.sh

---------

Co-authored-by: Bertie <[email protected]>
Co-authored-by: bertiethorpe <[email protected]>
Co-authored-by: bertiethorpe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants