-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified QR scanning #755
Unified QR scanning #755
Conversation
Welcome first-time contributor :) Changes look good, I will test them today. Thanks in advance! Btw, you can add your SN nym to contributors.txt if you want to have Can you also format/lint your code? Our CI failed because of this:
|
e13972b
to
0e36b3d
Compare
Tested the code manually with a unified invoice that Mutiny generated since I wasn't able to reliably scan the QR code with my webcam [0]
However, I was able to scan it once and it entered some numbers into the invoice field. Not sure if that's relevant, it's probably just my webcam being bad. But @huumn mentioned a good point here. User feedback in cases where we can detect they are doing something wrong (trying to scan onchain invoices for SN which is a LApp) sounds like the way to go. [0] because my webcam produces unsharp images, I assume. |
cc2b09a
to
a92b493
Compare
Merged! Feel free to add your nym to contributors.txt in another PR. Also send me your lightning address when you get a chance so I can send you some sats when this ships. |
adds support for scanning bip21 qrs on withdrawal.
I didn't really make an attempt to add any substantial bip21 support as we only use it for finding the lightning param.
Closes #734