-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wallet limit banner #699
Conversation
62a647f
to
0aec860
Compare
components/banners.js
Outdated
@@ -65,3 +67,50 @@ export default function WelcomeBanner () { | |||
</Alert> | |||
) | |||
} | |||
|
|||
export function WalletLimitBanner ({ dismissible }) { | |||
// TODO refactor this since it's mostly the same as the code for the welcome banner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not want to mix feature + refactor in one PR
No familiar with the code base but this MR looks good to me. Nice demo video as well @ekzyis! |
ACK the concept but I'm not sure the banner should be on the homepage. It should definitely be on the wallet pages and maybe show an indicator on the wallet ... banners on the homepage always feel like an assault. |
I agree that they are an assault but is this still a problem if you can dismiss them like the welcome banner? I see it as just a way to tell everyone about important things (like SNL being on air) I am open to remove it of course, just wanted to clarify that this isn't a banner that always shows up but only once until dismissed and also only if the wallet is over the limit.
but I also like this idea. But should this indicator then always be there while they are over the limit? Or also just once until clicked? I think both approaches could be confusing since: Maybe we could create a notification if someone goes over the limit? Then they would only need to check their notifications and it's a consistent UX regarding the indicator behavior. |
Maybe it can work like this:
|
4672396
to
d01164f
Compare
Did that in d01164f now: 2023-12-21.22-24-23.mp4 |
https://stacker.news/items/356071
2023-12-20.06-14-02.mp4
ignore actual wallet balance in screenshots, I manually set
limitReached
to trueSo basically, this adds a banner that only shows up if the wallet balance is over the limit. It can be dismissed on the front page but it will always appear in the wallet (if over the limit).