Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider mutes before sending push notifications #697

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Dec 18, 2023

Not tested yet. Also, I only updated the query in notifyItemParents. Need to make sure that only this query needs an update (but I think so).

Fix #662


Tested now and thus ready for review:

2023-12-19.15-45-00.mp4

@ekzyis ekzyis marked this pull request as draft December 18, 2023 16:26
@ekzyis ekzyis force-pushed the 622-receiving-push-notifications-from-muted-people branch from c48cec0 to 8b82fc5 Compare December 18, 2023 16:28
@ekzyis ekzyis force-pushed the 622-receiving-push-notifications-from-muted-people branch from 8b82fc5 to 9346906 Compare December 19, 2023 14:45
@ekzyis ekzyis added the bug label Dec 19, 2023
@ekzyis ekzyis marked this pull request as ready for review December 19, 2023 14:49
@huumn huumn merged commit 9f7f093 into stackernews:master Dec 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving push notifications from muted people
2 participants