Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the AD badge to be alongside other item info badges #647

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

SatsAllDay
Copy link
Contributor

Closes #638

Instead of using embellishUser for the AD badge, I introduced an extraBadges prop for ItemInfo and pass it there, allowing for better placement.

I also created an ad post in the seed file in this PR for easier testing.

image

@huumn huumn merged commit 44e12a4 into stackernews:master Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ad tag next to sub tag
2 participants