-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image refactor refactor #541
Conversation
😂 the title |
Mhh, or wait. I have a better solution: If This would also fix the markdown in my bio. I use edit: Also 19d2f5f throws an errors on |
9cdbc24
to
78a6167
Compare
We no longer distinguish between `undefined` and `null` for `srcSet`.
I think this is not required since `showImage` will always stay false if tab !== 'preview' or me?.clickToLoadImg are true.
78a6167
to
2097399
Compare
2097399
to
967651b
Compare
Is this good to merge or does this need to be fixed? |
Fixed in 9b204ae using optional chaining: So this is good to merge now |
srcSet
which no longer made sense<ImageOriginal>
<ImageOriginal>
clickToLoadImg
toimgproxyOnly
since we no longer use clicking to bypass setting. We simply show the link for the user to click. (I also never liked the name of the setting)