Toast success and danger for donate action #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danger case was already handled by the common `Form` component, but success wasn't happening. I like having feedback on actions like this one. Now, the danger toast is also specific to the donate action, and not just the underlying JS error that occurred (which is logged, instead).
|
I wonder if we should use the lightning visual effect instead of success toast on successful donation. That feels more appropriate? Or both? Idk Edit: Perhaps lightning + success toast, because not all users have the lightning enabled, so if we did lightning only, there'd be no positive feedback, which is pretty much the entire point of this PR :P |
|
Yeet! The lightning bolt would be cool for a little more visual feedback but I'm going to merge this and that can be done in another pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Danger case was already handled by the common
Formcomponent, but success wasn't toasted. I like having feedback on actions like this one.Now, the danger toast message is also specific to the donate action, and not just the underlying JS error that occurred (which is logged, instead).