Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sats / ccs format in item details #1805

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Use sats / ccs format in item details #1805

merged 2 commits into from
Jan 6, 2025

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Jan 5, 2025

I think this:

2025-01-05-175920_515x328_scrot

looks better than this:

2025-01-05-175939_513x401_scrot

On mobile:

localhost_3000_(iPhone SE) (1)

stacker news_(iPhone SE) (1)

@ekzyis ekzyis added enhancement improvements to existing features ux labels Jan 5, 2025
@riccardobl
Copy link
Member

+1 much easier to compare stacked sats vs cc on desktop, but i would reduce line-height for mobile so that it doesn't look like stacked and (comments) are two different entries.
Or maybe it could be reworked like this

title
         value
title 2
        value2

for mobile

@huumn
Copy link
Member

huumn commented Jan 5, 2025

We have a css class .line-height-md and .line-height-sm I use in modals most of the time.

@ekzyis
Copy link
Member Author

ekzyis commented Jan 5, 2025

I used row-gap: 0.75rem + line-height: 1.25 now. line-height alone didn't help because it increases the height of every line, so it does not separate rows visually from each other. row-gap does that.

It now looks like this:

2025-01-06-004220_368x395_scrot

@huumn huumn merged commit b37a12b into master Jan 6, 2025
6 checks passed
@huumn huumn deleted the item-details branch January 6, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improvements to existing features ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants