Fix insecure default id for invites #1789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cuid
has been deprecated due to security, see README.cuid2
is now recommended but when I tried to usecuid(2)
as the default in our Prisma schema as mentioned in the Prisma docs, it didn't work.Since Prisma is pretty weird anyway and I have more trust in
pgcrypto
, I decided to usegen_random_bytes
from it.I used hex encoding because it's url-safe, I only wanted to have alphanumeric characters and Postgres only supports base64 or hex as encodings.
TODO:
Additional Context
cuid
defaultdbgenerated
contains a string. prisma/prisma#14917 (fixed usingdb pull
as mentioned in the ticket)Checklist
Are your changes backwards compatible? Please answer below:
it doesn't fix existing invite links
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7
. Created invite link with default id and custom id.For frontend changes: Tested on mobile, light and dark mode? Please answer below:
n/a
Did you introduce any new environment variables? If so, call them out explicitly here:
no