feat: daily stacked and spent sats notification #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soxasora
commented
Dec 24, 2024
There was a problem hiding this comment.
realized I didn't push this before, sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Daily stacked and spent sats summary addressing #1751
It features a brief summary of how much a user has stacked (including rewards) and spent in 24h.
Data is collected from the
user_stats_daysview following the America/Chicago timezone, if the record is still not available past the midnight for other timezones, the latest record available is pulled (2 day interval, limited to 1).SN-worker triggers a push notification every midnight
The notification itself is clickable and links to the full Satistics page
Screenshots
Notification
Settings
Additional Context
#1750 will not conflict with this new type of notification, we would need to give it a filter category though!
Checklist
Are your changes backwards compatible? Please answer below:
It needs migrations to allow toggling and scheduler support but other than that these are only additions!
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6, data collection happens unequivocally from user_stats_days, the notification also has a fallback to the previous one if newer data isn't available. Push notifications are not tested yet but follows the same design as the others, worker correctly starts and finish the job at midnight
For frontend changes: Tested on mobile, light and dark mode? Please answer below: The displayed notification follows the same design language as the others
Did you introduce any new environment variables? If so, call them out explicitly here: No
TODO: