Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invite paid action #1681

Merged
merged 1 commit into from
Dec 4, 2024
Merged

invite paid action #1681

merged 1 commit into from
Dec 4, 2024

Conversation

huumn
Copy link
Member

@huumn huumn commented Dec 4, 2024

This cherry picks the invite paid action and the final removal of serializable txs from #1678

Additionally, it increases the minimum length of invite code to be 8 characters rather than 4. I debated removing the feature. These invite links are redeemable for money.

QA: 6. I redeemed an invite gift successfully, then couldn't redeem it after the limit was reached.

@@ -100,7 +102,8 @@ export default async function performPaidAction (actionType, args, incomingConte
} catch (e) {
// if we fail with fee credits or reward sats, but not because of insufficient funds, bail
console.error(`${paymentMethod} action failed`, e)
if (!e.message.includes('\\"users\\" violates check constraint \\"msats_positive\\"')) {
if (!e.message.includes('\\"users\\" violates check constraint \\"msats_positive\\"') &&
!e.message.includes('\\"users\\" violates check constraint \\"mcredits_positive\\"')) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsequential spillover from cherrypick

@huumn huumn merged commit 713227b into master Dec 4, 2024
6 checks passed
@huumn huumn deleted the invite-paid-action branch December 4, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant