-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login 2fa (totp) #1680
Open
riccardobl
wants to merge
7
commits into
stackernews:master
Choose a base branch
from
riccardobl:login2fa
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Login 2fa (totp) #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
riccardobl
commented
Dec 4, 2024
export function generateTotpSecret ({ label = 'stacker.news - login' }) { | ||
const totp = getTotp({ label }) | ||
return { | ||
base32: totp.secret.base32, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is the setup-key in google authenticator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add optional TOTP 2fa for login.
Partially solves: #1439
Screenshots
Additional Context
next-auth does not support 2fa natively.
There are several ways to implement it, but i've come up with this custom solution that is tailored to sn.
The goals of this implementation are:
To achieve this i've implemented 2fa as two middlewares:
Most of the logic is contained in
/lib/auth2fa
As reference i've used the github 2fa flow.
Checklist
Are your changes backwards compatible? Please answer below:
yes
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
6
For frontend changes: Tested on mobile, light and dark mode? Please answer below:
not yet
Did you introduce any new environment variables? If so, call them out explicitly here:
no