Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never update author of item on edit #1401

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Never update author of item on edit #1401

merged 3 commits into from
Sep 13, 2024

Conversation

ekzyis
Copy link
Member

@ekzyis ekzyis commented Sep 13, 2024

Description

The combination of #1393 + #644 made it possible that the author of an item could change from anon to a user and vice versa.

This PR makes sure that during item updates, the author is never changed.

Checklist

Are your changes backwards compatible? Please answer below:

yes

On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:

8

  • switched accounts and edited item with different author and made sure author doesn't change (using e04f64e before edit option disappears on switch)
  • made sure hash+hmac edit only shows for anonymous items if anonymous

For frontend changes: Tested on mobile? Please answer below:

n/a

Did you introduce any new environment variables? If so, call them out explicitly here:

no

@ekzyis ekzyis added the bug label Sep 13, 2024
@huumn huumn merged commit c897503 into master Sep 13, 2024
6 checks passed
@huumn huumn deleted the fix-author-update branch September 13, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants