BugFix: Terminal render too many times causing performance freeze #384
+257
−234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I've detected a performance bottle neck on page load, opened the console and saw this
Before the fix the Terminal tabs would get rendered too many times.
Analysis
I believe using a big function call with many inputs that change often and having a big ass interface defined underneath is an anti pattern to the framework used here, memo.
Solution
Move the terminal and it's 3 tabs to a different component that doesn't rely on inputs allows for better template caching and avoids re renders of this expensive resource.
Proposed changes
Results
I believe Largest contentfull paint after a prompt is largely improved and so is the total blocking time.
Please let me know what you think of this improvement 🙏🏽