Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Ready for review) - Small visual fix. Add background for chat window(currently transparent and looks ugly) #350

Merged

Conversation

wonderwhy-er
Copy link
Collaborator

@wonderwhy-er wonderwhy-er commented Nov 20, 2024

This PR includes two changes:
Enhance Chat Component Background:

Updated the BaseChat component to include a background and border styling. This resolves a visual issue where the area under the chat component appeared broken

Before:
Screenshot 2024-11-20 at 16 48 16

After:
Screenshot 2024-11-20 at 16 46 36

@wonderwhy-er wonderwhy-er changed the title Ready for review. Small Visual Fix. Add background for chat window (Ready for review) - Small visual fix. Add background for chat window(currently transparent and looks ugly) Nov 20, 2024
@kekePower
Copy link

Love it. I've noticed the same and, as you, thought it felt broken.

@wonderwhy-er
Copy link
Collaborator Author

Love it. I've noticed the same and, as you, thought it felt broken.

If you can check-out and confirm it works for you I can marge myself.
Just want second opinion that it works and looks allright

@wonderwhy-er
Copy link
Collaborator Author

I use git fetch remote pull/350/head:pr-350 to pull and test PRs locally fyi.

@kekePower
Copy link

LGTM. Tested and it looks great using the dark theme.

@wonderwhy-er wonderwhy-er merged commit 166c79d into stackblitz-labs:main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants