Fixing Ollama (and other dynamicModel providers) (re: #259) #344
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #259.
the main bug effecting #259 is that
MODEL_LIST
did not includedynamicModels
(for providers that support it). In factdynamicModels
were not fetched at all, meaning this is not only breaking Ollama provider, but also any other provider + model that usesdynamicModels
.that resulted in falling back to the
DEFAULT_MODEL
(i.e.claude-3-5-sonnet-latest
) being selected as thecurrentModel
because this condition always failed to find requested model:https://github.com/coleam00/bolt.new-any-llm/blob/88700c24526bb5d722d48e51d0f2bb1cc77fb72a/app/lib/.server/llm/stream-text.ts#L51-L60
this PR constructs a list of
dynamicModels
by fetching it from all providers in parallel, and fixesMODEL_LIST
to include those models as well.let me know if you have any questions, and thanks for creating and maintaining this fork!