Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [UX] click shortcut in chat to go to source file in workbench #330

Merged

Conversation

hgosansn
Copy link

@hgosansn hgosansn commented Nov 18, 2024

Greetings earthlings 🙋🏽

About me

First contribution here

I've found a topic on the thinktank forum

https://thinktank.ottomator.ai/t/ux-enhancement-ctrl-click-shortcut-in-chat-to-go-to-source-file-in-workbench/478

i wanted to start contributing small to learn the codebase and eventually do some more.

Screencast.From.2024-11-18.23-09-34.mp4

Summary

Allow clicking on files ("Artifacts") in the chat to open them in the Workbench.

Proposed changes

  • Function in the Artifact class to open in workbench
  • Made usage of the WORK_DIR variable in my changes
  • Went a little further and replaced the variable in the codebase
  • Reused a function to make filePaths relative
  • Little humble test class to verify WORK_DIR Changes don't break the Regex

Pull request checklist

  • Test for the changes have been added
  • Validate the design and architecture

@hgosansn hgosansn changed the title [UX] click shortcut in chat to go to source file in workbench feat: [UX] click shortcut in chat to go to source file in workbench Nov 18, 2024
@hgosansn hgosansn force-pushed the ux-click-open-file-in-chat branch from 039c93c to d419a3c Compare November 18, 2024 23:27
@chrismahoney
Copy link
Collaborator

@wonderwhy-er I tested this okay, it links file names in chat to the file in editor. I'm 👍 for it but would like another set of eyes if you get a chance.

@chrismahoney chrismahoney merged commit fe80e5f into stackblitz-labs:main Nov 19, 2024
1 check passed
@wonderwhy-er
Copy link
Collaborator

Tested, looks good
Thanks for quality of life contribution @hgosansn

If you and your PR is featured by youtubers do you want some page, social network, profile to be shown as kudos?

@hgosansn
Copy link
Author

@wonderwhy-er Happy that i could help, i'll continue looking for small to medium improvements i can make in here. This small feat is my way to say Hi 👋🏽 . Still you can find all my contacts at https://hson.fr.

About the next steps for me,

  1. I saw an issue that somehow the project's node dev server isn't started when opening projects from the sideNav. It does that on Bolt.new, i think it's another QOL.
    (When can see the example in the linked video)

  2. Would it be helpful building integration/non regression tests, that mock an LLM response to be Sure the UI loads and runs basic responses from PRs ?

@hgosansn hgosansn deleted the ux-click-open-file-in-chat branch November 19, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants