Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bedrock cerebras and pixtral #324

Closed
wants to merge 0 commits into from

Conversation

ArulGandhi
Copy link

Added amazon bedrock (token limit manual change reqd to use) and added cerebras as asked in another pr. pixtral was restored. @coleam00 Please look into the artificial api token limit for amazon bedrock, it's important to have bedrock as well.

@@ -56,6 +62,25 @@ export function getGroqModel(apiKey: string, model: string) {
return openai(model);
}

export function getAmazonBedrockModel(apiKey: string, model: string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we will need to add more to add support for this, as it requires 3 parameters instead of one API key.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a test run with this, and it seems to be working. If you wanna see just lmk.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is that its not possible to set API key from UI right?
image

It only works when set locally in env parameters

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can add it later it just should not show in the list if API key is not set

Or, we should allow setting it from UI somehow.

We will need for some providers like openai like or local ones like ollama and lm studio to give url + api key + additional parameters

staticModels: [
{ name: 'anthropic.claude-3-5-sonnet-20241022-v2:0', label: 'Claude 3.5 Sonnet v2', provider: 'Bedrock' },
],
getApiKeyLink: 'https://platform.deepseek.com/api_keys'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a mistake, I forgot to change the url when I was merging changes manually after syncing my fork. I'll correct that asap

@wonderwhy-er
Copy link
Collaborator

There is also conflict.
I don't mind merging but it would be good if it worked from UI too.

Or at least hide it from UI if API key is not set

If hosted without a key it will shop up in the list and not work.

@ArulGandhi
Copy link
Author

ArulGandhi commented Nov 19, 2024

Could you look into it? I would, but I prefer working on the backend, and it'd be greatly 👍 appreciated.

@wonderwhy-er
Copy link
Collaborator

Bit later than. Need to do some other things first.

@dustinwloring1988
Copy link
Collaborator

@ArulGandhi can you please update this

@dustinwloring1988 dustinwloring1988 added WIP Work In Progress model-provider This is a model provider addition labels Dec 2, 2024
@ArulGandhi
Copy link
Author

I'll update soon. Seeing that token limits are now implemented smoothly, we can make this work, 100%. Give me a day

@SteffanWolter
Copy link

Looking forward. Bedrock support would be amazing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model-provider This is a model provider addition WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants