-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added speech to text capability #275
Added speech to text capability #275
Conversation
Awesome! Once we settle in on some provider work this is on my radar for when we've got room for feature adds. 👍 |
I actually pulled it and merged with provider work. Tested here and seems to work. When user submits we should clean out ongoing text so that when he speaks next time its new text. There are some other potential UX changes. Use "Hello Google/Alexa" style wake up and go to sleep commands? Ugh so exciting, thanks for your great work @navyseal4000 |
Oof, I started working on #281 before this was created. |
@wonderwhy-er Can we combine the two so it's not time wasted? |
that is why I am for posting PRs early in draft mode for early feedback. |
Won't have time this morning to get the enhancements done, I'll try to get to them later tonight |
In fact if you'd like, feel free to finish this @milutinke and if you can, feel free to take the author role. Just lmk if you do so we don't both work on it tonight |
I had quite a busy day, sorry for the late reply, I won't have the time to do anything at least up to 22. of November. Edit: |
#Voice support is an awesome feature to support, I’m really biased toward it from a human computer interface perspective so just full disclosure. If we can all work together towards integration of this and #281 I am more than happy to help out where I can. Cheers! Quick Edit: I’ll qualify this by saying this feature may end up on the roadmap in a certain priority, so please don’t see that as a disappointment; just making sure all the wheels roll in the same direction. 🤓 |
I am pretty excited for this feature and already tested @milutinke solution that it works pretty well with one exception. I am honestly willing to merge this and then add those improvements as separate PRs so that ball is rolling. May be will get to this in the evening And we can add other things in separate PRs |
4189edc
to
a896f3f
Compare
@wonderwhy-er Ready for retesting. I got the fix working, but not the additional features with voice mode yet. Adding "enhance voice mode" as a goal in the readme might be a good idea, but I'll leave that determination up to you. |
This reverts the constant change for the default model in commit a896f3f.
@wonderwhy-er Regarding the discussion in the #281, we can get this merged first, since @navyseal4000 continued working on it. |
Looking at it :) |
Just took a look, I see you are stopping microphone on submit now. I was away from computer for this weekend. I am ready to merge, but we need to resolve conflict first. I did it locally but can't push into your PR. |
Verify your system default microphone is the one you're testing with, as that's the primary limitation of this initial text to speech implementation for voice prompting.