fix error handling

stackblitz-labs · Nov 25, 2024 · 14c289f · 14c289f
1 parent 60bbee4
commit 14c289f
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/app/github/GitHubAuth.tsx b/app/github/GitHubAuth.tsx
@@ -87,11 +87,16 @@ export function GitHubAuth({ onAuthComplete, onError, children }: GitHubAuthProp
       });
 
       if (!response.ok) {
-        const errorData = await response.json().catch(() => ({} as GitHubErrorResponse));
-        throw new Error(
-          errorData?.error || 
-          `Failed to start authentication process (${response.status})`
-        );
+        let errorMessage = `Failed to start authentication process (${response.status})`;
+        try {
+          const errorData: GitHubErrorResponse = await response.json();
+          if (errorData.error) {
+            errorMessage = errorData.error_description || errorData.error;
+          }
+        } catch {
+          // Use default error message if JSON parsing fails
+        }
+        throw new Error(errorMessage);
       }
 
       const data: DeviceCodeResponse = await response.json();