-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stackable-telemetry): Improve stackable-telemetry to make it easier to build the TraceGuard #901
Draft
NickLarsenNZ
wants to merge
9
commits into
main
Choose a base branch
from
stackable-telemetry-builder-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
NickLarsenNZ
force-pushed
the
stackable-telemetry-builder-improvements
branch
3 times, most recently
from
October 24, 2024 20:55
a2d2ee2
to
98bac73
Compare
NickLarsenNZ
force-pushed
the
stackable-telemetry-builder-improvements
branch
from
October 25, 2024 09:56
36abd6a
to
9468ff6
Compare
I like it! |
Thanks. It is basically done, there is one thing left to refactor (and enable console log formats), but before merging I will document the pub items (and enable warn on missing docs). |
NickLarsenNZ
force-pushed
the
stackable-telemetry-builder-improvements
branch
from
October 25, 2024 15:39
9468ff6
to
71ec75f
Compare
…icker access to common settings from subscriber specific settings
…le and From impls as a config shortcut similar to before this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#639.
Problem
It is cumbersome to configured the various subscribers to be enabled at runtime. Using @soenkeliebau's code example:
The purpose of the builder is to allow overriding of the the defaults, however in the current state, the function parameters for the subscribers (console and otlp exporters) break that, and it will only get messier as config options are added.
Solution
Add common and subscriber specific configuration through a Settings builder (suggested by @Techassi). The previous example would then look like:
Caution
This is work in progress, so it might change, but the essence remains the same.
Todo: update this before merging.
Definition of Done Checklist
Author
Reviewer