Feature/modify base manifest sample #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayamin
reviewed
Jan 15, 2024
docs/user-guide.md
Outdated
| Therefore, setting values to fields marked `<config.yaml overrides this field>` in `base_manifest.yaml` is not necessary. | ||
| Fields marked `<config.yaml overrides this field>` in `base_manifest.yaml` are set to different values for each load test. The value of this field will be replaced by the value in `config.yaml` respectively when Gatling Commander runs. Therefore, setting values to fields marked `<config.yaml overrides this field>` in `base_manifest.yaml` is not necessary. | ||
|
|
||
| \* Gatling Commander once loads `base_manifest.yaml` value to Gatling struct object before replaced by `config.yaml`. So the type of `base_manifest.yaml` field vlaue must be matched to Gatling struct field one. If type not match, like following error will be occured. |
There was a problem hiding this comment.
@okmtz
【IMO】
Corrected sentences.
Suggested change
| \* Gatling Commander once loads `base_manifest.yaml` value to Gatling struct object before replaced by `config.yaml`. So the type of `base_manifest.yaml` field vlaue must be matched to Gatling struct field one. If type not match, like following error will be occured. | |
| \* Gatling Commander loads `base_manifest.yaml` value to Gatling struct object before it replaces the value by `config.yaml`. So the type of `base_manifest.yaml` field value must be matched to Gatling struct field one. If type not match, an error like following will occur. |
There was a problem hiding this comment.
@kayamin
commit suggestion and rebase with my old commit !
thank you !
okmtz
force-pushed
the
feature/modify-base-manifest-sample
branch
from
7bce214 to
fd0a81e
Compare
kayamin
reviewed
Jan 15, 2024
Co-authored-by: kayamin <[email protected]>
kenz
reviewed
Jan 15, 2024
| `base_manifest.yaml`に`<config.yaml overrides this field>`と記載があるフィールドは、負荷試験ごとに異なる値が設定されます。 | ||
| これらのフィールドの値は、Gatling Commanderの実行時に`config.yaml`の値でそれぞれ置き換えられます。 | ||
| そのため、`base_manifest.yaml`での値の変更は不要です。 | ||
| `base_manifest.yaml`に`<config.yaml overrides this field>`と記載があるフィールドは、負荷試験ごとに異なる値が設定されます。これらのフィールドの値は、Gatling Commanderの実行時に`config.yaml`の値でそれぞれ置き換えられます。そのため、`base_manifest.yaml`での値の変更は不要です。 |
There was a problem hiding this comment.
【IMO】 base_manifest.yamlによる値の変更がいつの話か、どのようなメリットがあるかを明示するとよさそう。
Suggested change
| `base_manifest.yaml`に`<config.yaml overrides this field>`と記載があるフィールドは、負荷試験ごとに異なる値が設定されます。これらのフィールドの値は、Gatling Commanderの実行時に`config.yaml`の値でそれぞれ置き換えられます。そのため、`base_manifest.yaml`での値の変更は不要です。 | |
| `base_manifest.yaml`に`<config.yaml overrides this field>`と記載があるフィールドは、負荷試験ごとに`config.yaml`の値で上書きされます。そのため、`base_manifest.yaml`の値を変更する事なく複数の負荷試験を連続して実行できます。``` |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
config/base_manifest.yamlparallelism field value.config/base_manifest.yamland Gatling struct field in related docs.Checklist
Please check if applicable