Add generator parameter to custom block renderer #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It allows to render block inside wrapper
sstur
reviewed
Mar 12, 2019
| @@ -30,7 +30,7 @@ type RenderConfig = { | |||
| style?: StyleDescr; | |||
| }; | |||
|
|
|||
| type BlockRenderer = (block: ContentBlock) => ?string; | |||
| type BlockRenderer = (block: ContentBlock, generator: MarkupGenerator) => ?string; | |||
There was a problem hiding this comment.
The second parameter should be optional.
Suggested change
| type BlockRenderer = (block: ContentBlock, generator: MarkupGenerator) => ?string; | |
| type BlockRenderer = (block: ContentBlock, generator?: MarkupGenerator) => ?string; |
sstur
reviewed
Mar 12, 2019
| type BlockStyleFn = (block: draftjs.ContentBlock) => RenderConfig|undefined; | ||
| type EntityStyleFn = (entity: draftjs.EntityInstance) => RenderConfig|undefined; | ||
| type BlockRenderer = (block: draftjs.ContentBlock) => string; | ||
| type BlockRenderer = (block: draftjs.ContentBlock, generator: MarkupGenerator) => string; |
sstur
reviewed
Mar 12, 2019
added 2 commits
March 13, 2019 08:49
sstur
requested changes
Mar 13, 2019
| @@ -30,7 +30,7 @@ type RenderConfig = { | |||
| style?: StyleDescr; | |||
| }; | |||
|
|
|||
| type BlockRenderer = (block: ContentBlock) => ?string; | |||
| type BlockRenderer = (block: ContentBlock, generator?: MarkupGenerator) => ?string; | |||
There was a problem hiding this comment.
I think you will also need to define a type for MarkupGenerator in this file (not to be confused with the typescript definitions which are totally different).
|
Hey @alexander-zolotykh I wonder whether you'd be finishing the PR? // cc @sstur I have the same issue and I'm trying to see my options for making it work. Thanks for the reply :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to render block inside wrapper without leaving styles (#33).