Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow list for notifications #1029

Merged
merged 1 commit into from
Oct 26, 2023
Merged

disallow list for notifications #1029

merged 1 commit into from
Oct 26, 2023

Conversation

sspenst
Copy link
Owner

@sspenst sspenst commented Oct 26, 2023

change email/push notification settings to be a disallow list instead of allow list

now when we add new notification types they will automatically be turned on instead of never being turned on

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ffbdb78) 81.99% compared to head (93c9796) 82.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1029      +/-   ##
==========================================
+ Coverage   81.99%   82.11%   +0.11%     
==========================================
  Files         201      201              
  Lines        5716     5724       +8     
  Branches     1255     1258       +3     
==========================================
+ Hits         4687     4700      +13     
+ Misses        982      978       -4     
+ Partials       47       46       -1     
Files Coverage Δ
lib/initializeLocalDb.ts 100.00% <100.00%> (ø)
models/schemas/userConfigSchema.ts 100.00% <ø> (ø)
pages/api/internal-jobs/worker/index.ts 94.02% <100.00%> (+0.18%) ⬆️
...s/api/internal-jobs/worker/sendPushNotification.ts 26.08% <100.00%> (+7.03%) ⬆️
pages/api/signup/index.ts 94.11% <100.00%> (+0.78%) ⬆️
pages/api/user-config/index.ts 94.44% <100.00%> (+1.42%) ⬆️
pages/api/user/index.ts 92.59% <ø> (ø)
pages/settings/[[...tab]].tsx 97.56% <0.00%> (ø)
.../api/internal-jobs/worker/sendEmailNotification.ts 42.10% <21.42%> (+13.53%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sspenst sspenst merged commit 8c189b5 into main Oct 26, 2023
10 of 11 checks passed
@sspenst sspenst deleted the disallow-list branch October 26, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant