Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More aliases (for Cameroon, Sudan, Brazil, Congo) #9

Merged
merged 4 commits into from
Mar 23, 2021
Merged

More aliases (for Cameroon, Sudan, Brazil, Congo) #9

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0152fd5
add aliases for DRC
Mar 19, 2021
2e1371c
add aliases for Cameroon
Mar 19, 2021
89e95ef
add aliases for Republic of Sudan
Mar 19, 2021
afd20a4
add aliases for South Sudan
Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions lib/normalize_country/countries/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,9 +459,13 @@ CD:
aliases:
- Congo Kinshasa
- Congo-Kinshasa
- DRC
- DR Congo
- Congo, The Democratic Republic Of The
- Congo, Democratic Republic of
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep Congo, The Democratic Republic Of The. It's valid: https://www.iso.org/obp/ui/#iso:code:3166:CD.

Version with parenthesis should be added too but this looks like a broader task for another day.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I meant to add the extra alias, and not delete the existing one. Will fix.

- Democratic Republic of Congo
- DR Congo
- RD Congo
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

French! Is this intentional? 😅

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mouais?

- DROC
- DRC
alpha2: CD
alpha3: COD
fifa: COD
Expand Down Expand Up @@ -549,6 +553,9 @@ CL:
emoji: "\U0001F1E8\U0001F1F1"
shortcode: ":flag-cl:"
CM:
aliases:
- Cameroun
- Cameroon, Republic of
alpha2: CM
alpha3: CMR
fifa: CMR
Expand Down Expand Up @@ -2256,6 +2263,12 @@ SC:
emoji: "\U0001F1F8\U0001F1E8"
shortcode: ":flag-sc:"
SD:
aliases:
- The Sudan
- The Sudan, Republic of
- Republic of Sudan
- Sudan, Republic of
- Sudan, Republic of the
alpha2: SD
alpha3: SDN
fifa: SDN
Expand Down Expand Up @@ -2393,7 +2406,10 @@ SR:
shortcode: ":flag-sr:"
SS:
aliases:
- South Sudan, Republic of
Copy link
Owner

@sshaw sshaw Mar 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we may as well add Republic of South Sudan and Republic of S. Sudan and similar entries for the others? In English Republic of South Sudan is how it would be formally written.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Although "S. Sudan" is a bit of a weird one, adding an extra permutation: abbreviations of "north", "south", etc. An "S." variation is included here and for a few other cases, but not for South Africa, South Georgia, North Macedonia etc.

- S. Sudan
- Republic of S. Sudan
- S. Sudan, Republic of
alpha2: SS
alpha3: SSD
fifa:
Expand Down