Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 admin buttons to Lobby #958

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

AyIong
Copy link
Collaborator

@AyIong AyIong commented Jan 8, 2025

Что этот PR делает

Добавил две кнопочки для админов в лобби:
Дать дилей и стартануть игру

При этом убрал кнопку смены CSS

Почему это хорошо для игры

Удобно

Изображения изменений

dreamseeker_bheyejzVpa.mp4

Тестирование

Ну типа

Summary by Sourcery

Introduce two new admin buttons in the lobby for starting the game and setting a delay, while removing the CSS change button. Improve the layout and styling of lobby buttons for enhanced usability.

New Features:

  • Add two new admin buttons in the lobby for starting the game and setting a delay.

Enhancements:

  • Remove the button for changing CSS in the lobby.
  • Adjust the layout and styling of lobby buttons for better alignment and spacing.

Copy link

sourcery-ai bot commented Jan 8, 2025

Reviewer's Guide by Sourcery

This pull request introduces two new admin buttons in the lobby for starting the game and setting a delay, while removing the existing CSS change button. It also includes updates to the CSS for button layout and appearance.

State diagram for game delay functionality

stateDiagram-v2
    [*] --> PreGame: Game Initializes
    PreGame --> DelayedStart: Admin clicks Delay
    DelayedStart --> NormalStart: 1.5 minutes delay
    DelayedStart --> LongDelay: 1984 days delay
    PreGame --> ImmediateStart: Admin clicks Start Now
    NormalStart --> [*]
    LongDelay --> [*]
    ImmediateStart --> [*]

    note right of DelayedStart
      Toggles between 1.5 minutes
      and 1984 days delay
    end note
Loading

File-Level Changes

Change Details Files
Added two new admin buttons to the lobby for starting the game and setting a delay.
  • Added a button to start the game immediately if the game state is pre-game.
  • Added a button to set a delay for the game start, with a toggle between 1.5 minutes and 1984 days.
modular_bandastation/title_screen/code/new_player.dm
modular_bandastation/title_screen/code/title_screen_html.dm
modular_bandastation/title_screen/code/asset_lobby.dm
Removed the CSS change button from the lobby.
  • Deleted the button for changing the CSS in the lobby.
  • Removed associated CSS change logic.
modular_bandastation/title_screen/code/new_player.dm
modular_bandastation/title_screen/code/title_screen_html.dm
modular_bandastation/title_screen/code/asset_lobby.dm
Updated CSS for lobby button layout and appearance.
  • Adjusted the position of left and right lobby buttons.
  • Removed row-reverse flex direction for bottom buttons.
  • Updated margin settings for lobby buttons.
  • Added styles for disabled lobby elements.
modular_bandastation/title_screen/html/title_screen_default.css
modular_bandastation/title_screen/html/title_screen_minimalistic.css

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Collaborator

@dj-34 dj-34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не смотрел

@Gaxeer Gaxeer merged commit 249961a into ss220club:master Jan 10, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants