forked from tgstation/tgstation
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ID skins port #1066
Open
Chorden523
wants to merge
10
commits into
ss220club:master
Choose a base branch
from
Chorden523:id_skins
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ID skins port #1066
+540
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces ID card stickers, allowing players to customize their ID cards with various cosmetic stickers. These stickers can be applied and removed from ID cards, and the changes are reflected visually on the card. The stickers are added to the game's loot pool and can be found in crates. Sequence diagram for applying ID stickersequenceDiagram
actor User
participant Card as ID Card
participant Sticker as ID Sticker
User->>Card: Use sticker on card
Card-->>Card: Check if sticker already applied
alt Has sticker
Card-->>User: Show warning message
else No sticker
Card->>User: Start application animation (2s)
User->>Card: Wait for animation
Card->>Sticker: Move sticker to card
Card->>Card: Add sticker overlay
Card->>Card: Update description
Card-->>User: Show success message
end
Class diagram for ID sticker systemclassDiagram
class obj_item_card_id_advanced {
+applied_sticker: obj/item/id_sticker
+card_sticker: mutable_appearance
+apply_sticker(user, sticker)
+remove_sticker(user, delete)
+item_interaction(user, tool, modifiers)
}
class obj_item_id_sticker {
+name: string
+desc: string
+icon_state: string
+id_card_desc: string
}
class obj_item_id_sticker_colored {
+color_list: list
+Initialize()
+attack_self(mob/living)
}
obj_item_id_sticker <|-- obj_item_id_sticker_colored
obj_item_card_id_advanced o-- obj_item_id_sticker : has
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
github-actions
bot
added
the
🖌️ Спрайты
Вы заработали свою миска-рис и кошко-жена. Партия гордится вами!
label
Jan 25, 2025
Gaxeer
reviewed
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🖌️ Спрайты
Вы заработали свою миска-рис и кошко-жена. Партия гордится вами!
📜 CL валиден
Этот чейнджлог будет успешно опубликован
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что этот PR делает
Портирует с парадизе наклейки на ID карты
Почему это хорошо для игры
Больше кастомайза для доноров.
Изображения изменений
Тестирование
Компилил и нажимал кнопочки
Changelog
🆑
add: Добавлены наклейки на ID карту
/:cl:
Summary by Sourcery
New Features: