Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID skins port #1066

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

ID skins port #1066

wants to merge 10 commits into from

Conversation

Chorden523
Copy link

@Chorden523 Chorden523 commented Jan 25, 2025

Что этот PR делает

Портирует с парадизе наклейки на ID карты

Почему это хорошо для игры

Больше кастомайза для доноров.

Изображения изменений

image
image

Тестирование

Компилил и нажимал кнопочки

Changelog

🆑
add: Добавлены наклейки на ID карту
/:cl:

Summary by Sourcery

New Features:

  • Added ID stickers that can be applied to ID cards.

Copy link

sourcery-ai bot commented Jan 25, 2025

Reviewer's Guide by Sourcery

This pull request introduces ID card stickers, allowing players to customize their ID cards with various cosmetic stickers. These stickers can be applied and removed from ID cards, and the changes are reflected visually on the card. The stickers are added to the game's loot pool and can be found in crates.

Sequence diagram for applying ID sticker

sequenceDiagram
    actor User
    participant Card as ID Card
    participant Sticker as ID Sticker

    User->>Card: Use sticker on card
    Card-->>Card: Check if sticker already applied
    alt Has sticker
        Card-->>User: Show warning message
    else No sticker
        Card->>User: Start application animation (2s)
        User->>Card: Wait for animation
        Card->>Sticker: Move sticker to card
        Card->>Card: Add sticker overlay
        Card->>Card: Update description
        Card-->>User: Show success message
    end
Loading

Class diagram for ID sticker system

classDiagram
    class obj_item_card_id_advanced {
        +applied_sticker: obj/item/id_sticker
        +card_sticker: mutable_appearance
        +apply_sticker(user, sticker)
        +remove_sticker(user, delete)
        +item_interaction(user, tool, modifiers)
    }

    class obj_item_id_sticker {
        +name: string
        +desc: string
        +icon_state: string
        +id_card_desc: string
    }

    class obj_item_id_sticker_colored {
        +color_list: list
        +Initialize()
        +attack_self(mob/living)
    }

    obj_item_id_sticker <|-- obj_item_id_sticker_colored
    obj_item_card_id_advanced o-- obj_item_id_sticker : has
Loading

File-Level Changes

Change Details Files
Added new translations for ID card stickers.
  • Added translation entries for various ID card stickers, including their nominative, genitive, dative, accusative, instrumental, and prepositional forms, as well as their gender.
modular_bandastation/translations/code/translation_data/ru_names.toml
Added ID card stickers to the arcade prize pool.
  • Added a new entry to the arcade prize pool to include a box of ID stickers.
modular_bandastation/objects/_objects.dm
Implemented ID card sticker functionality.
  • Added a new /obj/item/card/id/advanced type that supports stickers.
  • Added a new /obj/item/id_sticker type that represents the stickers.
  • Implemented the ability to apply stickers to ID cards.
  • Implemented the ability to remove stickers from ID cards.
  • Added visual representation of the applied sticker on the ID card.
  • Added a description of the sticker to the ID card's description.
  • Added a check to prevent painting ID cards with stickers.
  • Added various types of ID stickers with different icons, descriptions, and colors.
modular_bandastation/objects/code/items/id_stickers.dm
Added a spawner for ID card stickers.
  • Added a new spawner that spawns random ID stickers.
modular_bandastation/objects/code/effects/spawners.dm
Added a box for ID card stickers.
  • Added a new box that contains a number of random ID stickers.
modular_bandastation/objects/code/items/storage/id_stickers_box.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the 🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! label Jan 25, 2025
@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 25, 2025
@Chorden523 Chorden523 requested a review from Gaxeer January 26, 2025 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖌️ Спрайты Вы заработали свою миска-рис и кошко-жена. Партия гордится вами! 📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants