Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance: Underfloor Blobs #1064

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dj-34
Copy link
Collaborator

@dj-34 dj-34 commented Jan 25, 2025

Что этот PR делает

Closes #1062

Подпольные Блобы (они же гетто Блобы, они же вне станционные Блобы, они же Блобы на 3 этаже) теперь получают существенные дебаффы, в отличии от тех, кто решает выбрать место спавна в привычных техах.

Хар-ки:
400 ->700 тайлов для победы.
Стоимость ресурсов установки тайла Блоба 4 -> 8.

Почему это хорошо для игры

Гетто Блобы будут либо наши, либо без гетто 💪💀

Изображения изменений

image

image

Тестирование

Проверял на локалке.

Changelog

🆑
balance: Подпольные Блобы (они же гетто Блобы, они же вне станционные Блобы, они же Блобы на 3 этаже) теперь получают существенные дебаффы, в отличии от тех, кто решает выбрать место спавна в привычных техах.
/:cl:

Copy link

sourcery-ai bot commented Jan 25, 2025

Reviewer's Guide by Sourcery

This pull request introduces a mechanic that applies debuffs to underfloor blobs, making them more difficult to play. It also adds a debug tool to check the current z-level.

Class diagram for Blob-related changes

classDiagram
    class mob_eye_blob {
        +blobwincount: int
        +Initialize(mapload, starting_points)
        +Login()
        +update_blob_expand_cost(blob)
    }

    class debug_tool {
        +name: string
        +desc: string
        +icon: string
        +icon_state: string
        +attack_self(mob/user)
    }

    note for mob_eye_blob "Modified to handle underfloor blob mechanics"
    note for debug_tool "Temporary tool for testing z-level detection"
Loading

State diagram for Blob expansion costs

stateDiagram-v2
    [*] --> CheckLocation
    CheckLocation --> MainFloor: On main station floor
    CheckLocation --> UnderFloor: Not on main floor

    MainFloor: blob_expand_cost = 4
    MainFloor: Normal win condition

    UnderFloor: blob_expand_cost = 8
    UnderFloor: Higher win threshold (700)
    UnderFloor: Display debuff warning
Loading

File-Level Changes

Change Details Files
Added a function to determine if a given atom is on the main station floor.
  • Added a static list to store the main floor z-level for each map.
  • Added a proc to check if an atom is on the main station floor based on the map and z-level.
modular_bandastation/_helpers220/code/unsorted.dm
Added a debug tool to check the current z-level and main station floor.
  • Added a debug tool object.
  • Added functionality to the debug tool to display the current z-level, map name, main floor z-level, and whether the user is on the main station floor.
modular_bandastation/_helpers220/code/unsorted.dm
Modified blob expansion cost to be configurable via a global variable.
  • Changed the blob expansion cost from a constant to a global variable.
code/__DEFINES/blob_defines.dm
Implemented debuffs for blobs not on the main station floor.
  • Increased the blob win count if the blob is not on the main station floor.
  • Added a message to inform the player about the debuffs when they log in as a blob not on the main station floor.
  • Increased the blob expansion cost if the blob is not on the main station floor.
modular_bandastation/balance/code/blob.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ss220app ss220app bot added the 📜 CL валиден Этот чейнджлог будет успешно опубликован label Jan 25, 2025
@dj-34 dj-34 marked this pull request as draft January 25, 2025 07:25
@dj-34 dj-34 marked this pull request as ready for review January 26, 2025 02:32
@AyIong AyIong added the ⚖️ Баланс Идеальный баланс. Эталон гармонии... label Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚖️ Баланс Идеальный баланс. Эталон гармонии... 📜 CL валиден Этот чейнджлог будет успешно опубликован
Projects
None yet
2 participants