Refactoring IPN Response code

srmklive · Jan 5, 2017 · 9633ff7 · 9633ff7
1 parent 840fa20
commit 9633ff7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/README.md b/README.md
@@ -351,14 +351,9 @@ Suppose you have set IPN URL to **http://example.com/ipn/notify/** in PayPal. To
      */
     public function postNotify(Request $request)
     {
-        $request->merge(['cmd' => '_notify-validate']);
-        $post = $request->all();
-
-        $response = $this->verifyIPN($post);
-
-        session([
-            'ipn' => $response
-        ]);
+        $response = $this->parsePayPalIPN($request);
+
+        // Parse IPN response accordingly to your requirements.                      
     }        
     ```
 

diff --git a/src/Traits/IPNResponse.php b/src/Traits/IPNResponse.php
@@ -12,15 +12,13 @@ trait IPNResponse
      * Retrieve IPN Response From PayPal.
      *
      * @param \Illuminate\Http\Request $request
+     * @return array
      */
-    public function postNotify(Request $request)
+    protected function parsePayPalIPN(Request $request)
     {
         $request->merge(['cmd' => '_notify-validate']);
         $post = $request->all();
-        $response = $this->verifyIPN($post);
 
-        session([
-            'ipn' => $response,
-        ]);
+        return $this->verifyIPN($post);
     }
 }