Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement darkmode functionality in /profile route #79

Closed
wants to merge 8 commits into from

Conversation

wildcraft958
Copy link
Contributor

Fixes Issue

Closes #52

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

i have completed the feature implementationa s required using inline js script and some css

Copy link
Owner

@sristy17 sristy17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wildcraft958 its all good looks very fine but in dark mode bg is dark and modal box is light and vice versa in light mode can you just change that make both dark or both light.?

@sristy17 sristy17 added the kwoc-2024 Issue under KWOC 2024 label Dec 29, 2024
@wildcraft958
Copy link
Contributor Author

wildcraft958 commented Dec 29, 2024

Screenshot from 2024-12-29 23-05-12

i guess this works?

@wildcraft958
Copy link
Contributor Author

Screenshot from 2024-12-29 23-06-31

@pooranjoyb
Copy link
Collaborator

I guess you didn't fix the SignIn part?

image

@wildcraft958

@wildcraft958
Copy link
Contributor Author

@pooranjoyb bug has been fixed please review

@pooranjoyb
Copy link
Collaborator

Major Changes has been made by the maintainers (including code-fixes & ui-changes). Take a latest pull from kwoc-2024 and raise a PR. Closing this as there are many conflicts ://

Please check that, dark-mode will not work on any pages, you can add the dark-mode to the Login/Signup Page.

@wildcraft958

@pooranjoyb pooranjoyb closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kwoc-2024 Issue under KWOC 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Implement darkmode functionality in /profile route
3 participants