Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark-mode-profile #76

Closed

Conversation

wildcraft958
Copy link
Contributor

  1. [FEATURE] Implement darkmode functionality in /profile route [FEATURE] Implement darkmode functionality in /profile route #52
    has been added.
  2. Little bit of code cleaning

@@ -5,10 +5,10 @@ button.addEventListener('click', () => {
if (body.classList.contains('light-theme')) {
body.classList.remove('light-theme');
body.classList.add('dark-theme');
button.innerHTML = '<i class="fas fa-sun"></i>'; // Change icon for dark theme
button.innerHTML = '<i class="fas fa-sun"></i>';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

donot remove the comments

</head>

<body class="light-theme" id="body">
<link href="https://fonts.googleapis.com/css2?family=Raleway:ital,wght@0,100..900;1,100..900&display=swap" rel="stylesheet" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what did u do with other fonts?

class="w-full bg-[#7C3AED] text-white py-3 rounded-lg font-semibold hover:ring-opacity-80 active:bg-[#4C1D95] hover:shadow-lg transition-all duration-300 focus:ring-4 focus:ring-purple-300 focus:ring-opacity-50">
Submit
</button>
<button type="submit" class="w-full bg-purple-700 text-white py-3 rounded-lg font-semibold hover:ring-opacity-80 active:bg-purple-900 hover:shadow-lg transition-all duration-300 focus:ring-4 focus:ring-purple-300">Submit</button>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment?

class="w-full bg-[#7C3AED] text-white py-3 rounded-lg font-semibold hover:ring-opacity-80 active:bg-[#4C1D95] hover:shadow-lg transition-all duration-300 focus:ring-4 focus:ring-purple-300 focus:ring-opacity-50">
Submit
</button>
<button type="submit" class="w-full bg-purple-700 text-white py-3 rounded-lg font-semibold hover:ring-opacity-80 active:bg-purple-900 hover:shadow-lg transition-all duration-300 focus:ring-4 focus:ring-purple-300">Submit</button>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only commented in some specific parts no need to remove or change them

@@ -93,6 +93,7 @@
transform: rotate(360deg);
}
}
<<<<<<< HEAD
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update ur commits then push the pr

@sristy17
Copy link
Owner

  1. [FEATURE] Implement darkmode functionality in /profile route [FEATURE] Implement darkmode functionality in /profile route #52
    has been added.
  2. Little bit of code cleaning

hey there are many conflicts we cannot merge the pr i am closing this update your code take a pull then create a new pr, do not do code clean up we will do it just make the required changes, also make the card bg also dark make it suitable

@sristy17 sristy17 closed this Dec 21, 2024
@wildcraft958
Copy link
Contributor Author

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants