Update Cocoapods + bundle #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
commented
Oct 30, 2024
dfed
commented
Oct 30, 2024
| @@ -18,15 +18,13 @@ jobs: | |||
| - name: Setup Ruby | |||
| uses: ruby/setup-ruby@v1 | |||
| with: | |||
| ruby-version: '3.3.4' | |||
| ruby-version: '3.3.5' | |||
There was a problem hiding this comment.
ended up bumping this while I was here
dfed
commented
Oct 30, 2024
dfed
commented
Oct 30, 2024
Comment on lines
218
to
219
| @unknown default: | ||
| false |
There was a problem hiding this comment.
I really don't know why this was necessary. builds locally without it. But in pod lib lint I get the following error without:
/Users/dfed/source/Paralayout/ParalayoutTests/ViewDistributionBuilderTests.swift:206:9: error: switch covers known cases, but '(ViewDistributionItem, ViewDistributionItem)' may have additional unknown values
switch (lhs, rhs) {
^
/Users/dfed/source/Paralayout/ParalayoutTests/ViewDistributionBuilderTests.swift:206:9: note: add missing cases
switch (lhs, rhs) {
^
|
This is now passing CI! |
dfed
commented
Oct 30, 2024
Comment on lines
-11
to
-14
|
|
||
| s.test_spec 'Tests' do |test_spec| | ||
| test_spec.source_files = 'ParalayoutTests/*{.swift}' | ||
| end |
There was a problem hiding this comment.
I ended up removing this after all in 6602c13 so that we wouldn't have to support Cocoapod's construction of unit test targets. IMO we don't gain anything from having this here given that we have other CI runs executing the test suite.
NickEntin
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a dependabot alert. This fixes it.
Looks like the old SnapshotTesting pod was not compatible with the latest Cocoapods, so I had to move to SPM in the example project.