Replace assertions in slice method with alert func #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickEntin
force-pushed
the
nick/slice-no-assert
branch
from
ac373ea to
2efcd4c
Compare
dfed
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some valid use cases where you want to be able to slice more than the available width/height, such as when your content has a minimum size and your sizing rules allow for content to extend beyond the bounds if you view is sized beneath its ideal size. This replaces the assertions in the
slice(...)method with alert functions consumers can place breakpoints for, following the pattern we use for view alignment issues.Resolves #128