Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to bzlmod #104

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Migrate to bzlmod #104

merged 1 commit into from
Jan 18, 2024

Conversation

luispadron
Copy link
Collaborator

@luispadron luispadron commented Jan 17, 2024

This PR updates the Bazel support for bzlmod. It updates Bazel to 6.4.0 and the targets for better external support:

  • Adds manual tags to swift_library targets, this fixes bazel build //... failures since swift_library cannot import UIKit without being part of a top-level target like ios_framework.
  • Adds public visibility to the Paralayout swift_library this is useful for consumers who would like to package the library in a different context, say, a static framework or application.
  • Updates CI to use bazel test //... so it tests everything
  • Ran buildifier -r . to reformat all Bazel files

@luispadron luispadron requested a review from NickEntin January 17, 2024 20:06

module(
name = "paralayout",
version = "0.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "1.0.0"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wouldn't update this version in main directly (see example), it gets updated automatically based on when a release is made once we start using: https://github.com/bazel-contrib/publish-to-bcr

@luispadron luispadron merged commit 7fd14b0 into master Jan 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants