Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert version bump for AardvarkMailUI #155

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Revert version bump for AardvarkMailUI #155

merged 1 commit into from
Aug 28, 2024

Conversation

tobischw
Copy link
Collaborator

  • Reverts a version bump

@tobischw tobischw force-pushed the tschweiger/revert-podspec-changes-mailui branch from 78819b2 to c569b16 Compare August 28, 2024 19:16
dfed
dfed approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@dfed dfed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@tobischw tobischw merged commit 53f0ed4 into master Aug 28, 2024
2 checks passed
@tobischw tobischw deleted the tschweiger/revert-podspec-changes-mailui branch August 28, 2024 19:38
@justinseanmartin
Copy link
Collaborator

FYI - This wasn't a revert, that's a bit misleading. This changed the restriction from ~> 5.0.0 to ~> 5.1.0 and now changing it to ~> 5.0. That way, AardvarkMailUI can use Aardvark 5.1.0 that was recently published. Arguably, that should've been a 5.0.1 release and this wouldn't have been a problem. That said, I think it makes sense for AardvarkMailUI to be more lenient and to generally work with varying versions of Aardvark as long as there are non-breaking changes introduced.

@justinseanmartin justinseanmartin mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfed dfed dfed approved these changes

@justinseanmartin justinseanmartin Awaiting requested review from justinseanmartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobischw @justinseanmartin @dfed