Merge pull request #95 from connorcimowsky/master

Fix touch handling when dismissing the email compose view
square · Dec 18, 2020 · 8274f4e · 8274f4e
2 parents 3212862 + 9c1bae5
commit 8274f4e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Aardvark.podspec b/Aardvark.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name     = 'Aardvark'
-  s.version  = '3.4.4'
+  s.version  = '3.4.5'
   s.license  = 'Apache License, Version 2.0'
   s.summary  = 'Aardvark is a library that makes it dead simple to create actionable bug reports.'
   s.homepage = 'https://github.com/square/Aardvark'

diff --git a/Aardvark/ARKEmailBugReporter.m b/Aardvark/ARKEmailBugReporter.m
@@ -476,7 +476,6 @@ - (void)_showEmailComposeWindow;
     [self.mailComposeViewController beginAppearanceTransition:YES animated:YES];
 
     self.emailComposeWindow.rootViewController = self.mailComposeViewController;
-    [self.emailComposeWindow addSubview:self.mailComposeViewController.view];
     [self.emailComposeWindow makeKeyAndVisible];
 
     [self.mailComposeViewController endAppearanceTransition];
@@ -489,6 +488,8 @@ - (void)_dismissEmailComposeWindow;
 
     [self.mailComposeViewController.view removeFromSuperview];
     self.emailComposeWindow.rootViewController = nil;
+    // Manually hide the window so that UIKit stops retaining it
+    self.emailComposeWindow.hidden = YES;
     self.emailComposeWindow = nil;
 
     [self.mailComposeViewController endAppearanceTransition];