fix (engine/sqlite): normalize table names (#3162) #3657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to fix #3162, where in SQLite if
schema.sql
containedCREATE TABLE "users"
andquery.sql
containedSELECT * from users
, it would complainrelation "users" does not exist
, because the quotes don't match.I think this was happening because the
identifier
function (which removes quotes from table names) wasn't consistently being called everywhere in the parser. I went through and replaced all instances ofn.Table_name().GetText()
withidentifier(n.Table_name().GetText())
and that seems to have fixed the issue.I've also added a test which previously failed and now passes. Here's what the output was previously: