-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate data types from generic keywords #677
Conversation
I notice that data types are missing from db2 and singlestoredb dialects. I'm not sure whether keywords like DAY, MONTH, HOUR should be considered data types. Afaik one can use these in expressions like extract() or when writing an interval literal, but one can't use them when declaring a type, like The ARRAY keyword is trickier. It can be used in both data type declaration, but also when writing an Anyway... These are just some general thoughts. Not blockers for merging this. |
I'll get started on 1 and 2 |
With ARRAY it's more like I'm not sure either. Will need to do some more research and thinking. |
Looks good. Let's keep the ARRAY in your way for now. |
Thanks for the review and merge! I'll rebase #673 |
Part of preparations for PR #673
Copied from my comment:
I would want to then do a separate PR to separate out all of the data type information in
src/languages/*/*.keywords.ts
in these flat arrays in into a separate (optional) export in each file calledexport const dataTypes
, which would temporarily merged together withkeywords
to keep compatibility beforereservedDataTypes
in the next step is implemented