Fix error in incremental obfuscation when a KPI already exists (#14)

* Update ObfuscatorTest.pbix * Fix KPIs incremental obfuscation error
sql-bi · Mar 2, 2024 · b305f72 · b305f72
1 parent d9f2659
commit b305f72
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/assets/ObfuscatorTest.pbix b/assets/ObfuscatorTest.pbix
diff --git a/src/Dax.Vpax.Obfuscator/DaxModelObfuscator.cs b/src/Dax.Vpax.Obfuscator/DaxModelObfuscator.cs
@@ -67,6 +67,10 @@ void CreateKpiMeasure(DaxExpression kpi, string type)
             var text = new DaxText($"_{measureText.Value} {type}");
             text.ObfuscatedValue = $"_{measureText.ObfuscatedValue} {type}";
 
+            // It may already exist in case of incremental obfuscation
+            if (Texts.IsIncrementalObfuscation && Texts.Contains(text))
+                return;
+
             Texts.Add(text);
         }
     }

diff --git a/src/Dax.Vpax.Obfuscator/DaxTextCollection.cs b/src/Dax.Vpax.Obfuscator/DaxTextCollection.cs
@@ -13,11 +13,14 @@ public DaxTextCollection(ObfuscationDictionary? dictionary = null)
     {
         if (dictionary != null)
         {
+            IsIncrementalObfuscation = true;
             foreach (var text in dictionary.Texts)
                 Add(new DaxText(text.Value, text.Obfuscated));
         }
     }
 
+    public bool IsIncrementalObfuscation { get; }
+
     public int Count => _plaintexts.Count;
 
     public bool IsReadOnly => false;