Fix for TomConnection NotImplementedException #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or now reads this property. Also, implemented a few other properties that can be inferred from the TOM Server object.
… the passed connection object doesn't match any of the patterns.
|
The issue was introduced by this change (not blaming Darren, it's my own fault for having an IDbConnection that didn't implement |
albertospelta
approved these changes
Apr 10, 2024
|
@otykier The release is in progress and the new version 1.5.1 should be available within 10/15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to 1.5.0, Tabular Editor 3 is not able to collect VertiPaq Analyzer stats, because we use the TomConnection wrapper for an existing connection created using AMO/TOM.
In 1.5.0, the connection's State property is read inside the DmvExtractor. However, the State property was not mplemented for the TomConnection wrapper. This PR fixes that.